search

taskcluster / generic-worker

A generic worker for TaskCluster, written in go
22 stars 29 forks source link

Please call out .exe filename changes in changelogs #253

Open SimonSapin opened 4 years ago

SimonSapin commented 4 years ago

For Servo CI, we install generic-worker in a Windows AMI for EC2. This works by having a PowerShell script that runs at first boot. However this script runs non-interactively, and its output is not easy to get at.

Twice now I’ve bumped the version number in the script like this:

--- windows/first-boot.ps1
+++ windows/first-boot.ps1
@@ -36,7 +36,7 @@ New-NetFirewallRule -DisplayName "Allow livelog GET requests" `
 # Install generic-worker and dependencies
 md C:\generic-worker
 $client.DownloadFile("https://github.com/taskcluster/generic-worker/releases/download" +
-    "/v14.1.0/generic-worker-nativeEngine-windows-amd64.exe", "C:\generic-worker\generic-worker.exe")
+    "/v16.5.2/generic-worker-nativeEngine-windows-amd64.exe", "C:\generic-worker\generic-worker.exe")
 $client.DownloadFile("https://github.com/taskcluster/livelog/releases/download" +
     "/v1.1.0/livelog-windows-amd64.exe", "C:\generic-worker\livelog.exe")
 $client.DownloadFile("https://github.com/taskcluster/taskcluster-proxy/releases/download" +

Only to realize after after lengthy debugging that the filename has changed to generic-worker-multiuser-windows-amd64.exe, so the download fails with a 404 error.

When doing such upgrades I do read the change logs at https://github.com/taskcluster/generic-worker/releases. It would be nice if future such filename changes were called out in the change logs. Thanks!

petemoore commented 4 years ago

Sorry about this Simon! This is a very fair point, apologies that got missed. I'll update the historic release notes and make sure not to make the same mistake again.

SimonSapin commented 4 years ago

I wouldn’t really call it a mistake, having this kind of reminder is nice to have :)