rename SchemaTable -> SchemaViewer to match README, package name

taskcluster / react-schema-viewer

React Schema Viewer takes a schema ('json' | 'joi') as input and uses it to generate comprehensible views

Mozilla Public License 2.0

14 stars 9 forks source link

Closed djmitche closed 5 years ago

djmitche commented 5 years ago

I'm assuming this was accidental, but please lmk if there's a reason for it!

helfi92 commented 5 years ago

I'm thinking we can just take care of the issue in https://github.com/taskcluster/react-schema-viewer/issues/22. Feel free to close if you agree.

djmitche commented 5 years ago

Why not just land this now? I could make #22 based on this commit, if you prefer, I just don't see why..

helfi92 commented 5 years ago

I think it should be more like

import { SchemaTable } from 'react-schema-viewer';

with #22, we can probably do:

import { JSONSchemaTable, JoiSchemaTable } from 'react-schema-viewer';

Let me know what you think.

djmitche commented 5 years ago

Ah, OK, that makes a lot of sense. Thanks!