search

taskcluster / taskcluster-client-web

A Taskcluster client library for the browser
Mozilla Public License 2.0
3 stars 8 forks source link

Fix erroring of slugid implementation, migrate tests from tc-client #20

Closed eliperelman closed 6 years ago

eliperelman commented 6 years ago

Fixes #19.

eliperelman commented 6 years ago

In a nutshell, there were 2 problems when this was migrated from tc-client:

  1. The UUID implementation returned a string instead of a buffer, meaning no valid bitwise operations were actually going to happen.
  2. We were base64-ing the buffer itself instead of the stringified version of it.
eliperelman commented 6 years ago

Published in v5.0.1.