Add taskcluster-lib-urls to 'externals' - Githubissues

taskcluster / taskcluster-client-web

A Taskcluster client library for the browser

Mozilla Public License 2.0

3 stars 8 forks source link

Add taskcluster-lib-urls to 'externals' #34

Open edmorley opened 5 years ago

edmorley commented 5 years ago

Hi!

In #32, taskcluster-lib-urls was added to dependencies: https://github.com/taskcluster/taskcluster-client-web/pull/32/files#diff-b9cfc7f2cdf78a7f4b91a753d10865a2R47

However I think it needs to also be added to externals: https://github.com/taskcluster/taskcluster-client-web/blob/047a6fac91ab662fc15f025ff229acdbb98ec1d1/.neutrinorc.js#L18-L26

...so that it gets require()ed rather than being included in the bundle: https://unpkg.com/taskcluster-client-web@8.0.4/build/index.js

helfi92 commented 5 years ago

Agreed.