search

taskcluster / taskcluster-client-web

A Taskcluster client library for the browser
Mozilla Public License 2.0
3 stars 8 forks source link

Define and accept CredentialAgents #7

Closed djmitche closed 6 years ago

djmitche commented 6 years ago

As usual I'll let Travis run the tests..

djmitche commented 6 years ago

Let's hold off merging this, but this much seems to be working for me. I'm still confused by #8, though.

djmitche commented 6 years ago

OK, this turned into a pretty big change. I've tagged it as 3.0.0.

djmitche commented 6 years ago

OK, once again, tests are green. I don't like the assertRejected, but I couldn't get chai-as-promised to work as promised. Feel free to merge or fiddle with that, as you prefer :)

djmitche commented 6 years ago

Sorry to re-flag you for review early.. Github only showed me the whitespace nit and not the rest of the review. Now it's updated.