djmitche
commented
5 years ago I kind of thought that was the case. This is probably a good bug, rather than an RFC.
Note that the comment you've identified is a slightly different situation: the worker's payload says "upload file X as an artifact" but X doesn't exist when the task completes. Docker-worker ignores this situation (as the comment indicates) while IIRC generic-worker will mark the task as failed. The generic-worker behavior is preferred, but obviously there are some compatibility issues to deal with.
The issue you have identified seems to be around artifacts for which uploads are begun but never finished. That's a bug, and might even be worth fixing depending on the details (it might not be worth fixing if the fix is complex, as there is work on a new approach to artifacts that involves a new "object service").
mitchhentges
I ran into an issue where artifacts weren't created, but a build was still marked as a success. When I viewed the task, I could see the artifacts listed (even though they didn't actually exist) - I'd have to click on the artifact links to be informed that the files were missing.
I created a ticket in
taskcluster-webto show if artifacts were missing on-the-spot, but perhaps this should be taken one step further? Should we fail the build if, at the end, the artifacts declared in the task definition aren't actually available?(comment in Taskcluster code recommending(-ish) that we fail builds upon missing artifacts)