search

taskcluster / taskcluster-rfcs

Taskcluster team planning
Mozilla Public License 2.0
11 stars 19 forks source link

Bug 1573192 - remove email validation on metadata owner #153

Closed MihaiTabara closed 4 years ago

jgraham commented 4 years ago

We also had to workaround this problem for GitHUb workflow-pushed changes in wpt, so +1 on relaxing the constraints.

djmitche commented 4 years ago

/r? @tomprince

MihaiTabara commented 4 years ago

Adding some folks from the mobile world as we've talked about this in the past too. /r? @pocmo @eoger

Flagging @JohanLorenzo too from RelEng

MihaiTabara commented 4 years ago

I believe we're ready to enter the Phase: Final Comment state. @djmitche can I get some help with setting the proper label on this PR as I don't seem to have rights to do so.

djmitche commented 4 years ago

Done! When will that phase end?

MihaiTabara commented 4 years ago

@djmitche Based on the mechanics, I think we can leave it bake for another week maybe?

Also, do you think this is an important enough change deserving an email to tools-taskcluster? If so, I'm happy to do that.

djmitche commented 4 years ago

Sounds good -- so until next Tuesday?

Yeah, the idea of FCP is to broadcast far and wide that a change is being made in case there's someone in a hidden corner that has a reason not to make the change. tools-taskcluster is probably a good choice here.

MihaiTabara commented 4 years ago

@djmitche Yes, next Tuesday sounds good. I emailed the TC tools ML to raise more awarness on this. Thank you for your support!

armenzg commented 4 years ago

In Treeherder we have it defined as a string that we shorten to 50 chars if need be: https://github.com/mozilla/treeherder/blob/master/schemas/pulse-job.yml#L220-L226 https://github.com/mozilla/treeherder/commit/342f3db6d43c5132b4e8ec4c145370aa9dc62173

escapewindow commented 4 years ago

We use task.metadata.owner in github push cot verification. Since we're taking the value from the task as truth, I think this will be ok.

MihaiTabara commented 4 years ago

@djmitche Hi! The timeframe we've established for final phase on this RFC has expired yesterday, I think we're ready to move this under Phase: Decided and merge it. Please let me know if there's anything else I could help with.

djmitche commented 4 years ago

done!

MihaiTabara commented 4 years ago

Thank you!