search

taskcluster / taskcluster-tools

Tools for debugging, inspecting and managing Taskcluster
https://tools.taskcluster.net/
Mozilla Public License 2.0
26 stars 91 forks source link

compatibility with listClients API #518

Closed tuhina2020 closed 6 years ago

tuhina2020 commented 6 years ago

https://github.com/taskcluster/taskcluster-auth/pull/148 https://bugzilla.mozilla.org/show_bug.cgi?id=1436212 Handled the refactoring of listClients API @djmitche

eliperelman commented 6 years ago

From reading the associated auth PR, it looks like during the transition to the new API, it will switch from returning the clients in an array to returning the array at the clients property in an object. Am I understanding this correctly?

When the API switches to have a continuationToken, do we foresee any breakage from the introduction of this?

cc: @djmitche

djmitche commented 6 years ago

Yes, that's precisely the idea. It's a breaking change, and the point of this PR is to make tools work both with the old and new response bodies.

eliperelman commented 6 years ago

Thanks for your work here @tuhina2020!