Open hwine opened 6 years ago
Out of curiosity, what are the reasons for deploying from Travis rather than using Heroku's GitHub integration?
(I can think of one: being able to speed up the deploy slightly since re-uses the assets built on Travis, however now that builds are much faster with Neutrino 9 the benefit will be much less and so perhaps not worth the security/hassle trade-off?)
taskcluster-tools doesn't use Neutrino v9. fwiw, we plan to move to taskcluster-web (uses neutrino v9) in the near future.
Ah yes. But taskcluster-tools could still switch to using the more conventional Heroku GitHub integration in the meantime (at a slight deploy-time regression) right? And then either later upgrade to Neutrino 9, or else wontfix in favour of switching to taskcluster-web depending on the expected timeframe for it being ready.
This sounds good to me.
This sounds good to me.
@helfi92 I'm confused about which "this" this is ;) -- if you no longer need the heroku service account, please let me know in bug 1504696
Commented.
The key committed in #575 will not actually work after cutover to SSO. A new API key from a service account will be needed.
I'm sending emails to @helfi92 & @djmitche with details on approach. There need not be any downtime following those instructions.