search

taskcluster / taskgraph

Generates task dependency graphs for Taskcluster CI
Mozilla Public License 2.0
13 stars 35 forks source link

Fix remaining type checking errors #476

Open ahal opened 3 months ago

ahal commented 3 months ago

https://github.com/taskcluster/taskgraph/pull/475 refactored our Pyright type checking excludes to be per line rather than ignoring entire files. Fixing these remaining errors is a good first issue!

First ensure you can run pyright locally:

$ pip install -r requirements/dev.txt
$ pyright

You should see no errors. Next:

  1. Search for the string # type: ignore in the code base.
  2. Remove it.
  3. Run pyright and verify you see the error.
  4. Figure out how to fix the error.
  5. Submit a PR

Feel free to batch many fixes into one PR if you like. And no need to fix everything! This issue can be tackled a little bit at a time, possibly even by multiple contributors.

ahal commented 1 month ago

The change to switch to ignoring type errors line by line finally landed: https://github.com/taskcluster/taskgraph/commit/ae78c110445c749f189489ea9dd88ec04ae94930

So the instructions in this issue make sense now.