search

tasket / wyng-backup

Fast backups for logical volumes & disk images
GNU General Public License v3.0
251 stars 16 forks source link

Fix error when using Wyng with rclone #176

Closed ldeso closed 6 months ago

ldeso commented 1 year ago

A simple and perhaps not-so-elegant solution to issue #175.

Edit: actually this doesn't fix the issue. Edit 2: it does fix #175! :smiley: I forgot to apply the pull request on my local version of Wyng.

ldeso commented 1 year ago

Ah I see, thanks. I don't have time today but I can make and test the change tomorrow.

ldeso commented 1 year ago

I rebased to the '08wip' branch and changed the 'untar' assignment, wyng send works.

Just to see what happens, I also tested a version of Wyng with only the 'untar' change and that didn't work: wyng send would hang indefinitely. wyng send would only work with a version of Wyng that has just the rm -df change, or that has both the rm -df change and the untar change.

Edit: I tested this again and actually it works if I just change the untar assignment, the line with rm -df is not necessary. So I'm going to remove that rm -df commit if that's okay with you.

Edit 2: I improved the stability of my scripts for mounting with rclone and I was hit with this bug again today. So after all I believe it's safer to keep both changes. I restored the branch with both commits.

Edit 3: And now I get the error rm: cannot remove 'Vol_800c73/S_20230930-212454': Directory not empty, so there might still be a problem somewhere... This could be avoid by switching from rm -df to rm -rf, but wouldn't that be a bit risky? Or maybe the problem could be fixed from rclone's side...