tasket / wyng-util-qubes

Qubes integration for Wyng enables backup and restore by VM name
GNU General Public License v3.0
8 stars 2 forks source link

Use progress bar/status as default #28

Closed kennethrrosen closed 1 month ago

kennethrrosen commented 5 months ago

Currently, wyng will display progress using a combination of -u -verbose, but not with -u alone. There is concern that system logs may become overloaded with progress notifications if the util or wyng is run from crond or system unit. Showing backup and restoration progress is essential to time-management and user-friendliness.

Thus, the -u flag should default to showing progress, however minimal, with something akin to -u -quiet offering users a less verbose/log-overwhelming feature.

tasket commented 5 months ago

I'm not sure about the question of defaults. There are many copying and archival tools (like Duplicity) that will not show progress indicators unless asked, even when they have interactive terminal sessions.

How do you feel about showing progress in 10% increments?

kennethrrosen commented 5 months ago

Anything, even an ellipsis, would do, but at present there is only a colon until the backup or restore is completed. I also realize I'm generalizing, but in my mind, to serve as a potential qvm-backup replacement, users should see the progress from the outset. I do realize things like --show-progress are often not there by default, but I'm thinking of the no-so-tech-savy.

tlaurion commented 5 months ago

@tasket I agree the behavior is a bit confusing and incomplete bwtween wyng-backup/wyng-util-qubes:

wyng

sudo wyng --dest qubes-ssh://wyng-wdcloud:root@Insurgo-LabRouter/mnt/Backups/nv41 --local qubes_dom0/vm-pool --verbose --authmin 1080 --dedup --remap --all send -u

excerpt:

Volume 'vm-heads-tests-deb12-nix-omnigul-private':  42.1MB
(reduced 81221.5MB)

Volume 'vm-heads-tests-deb12-nix-private':  344.3MB
(reduced 91196.8MB)

Note there is no progress output in verbose until final size is outputted and reduced is finally printed at the end of the process. This might need to be changed so that verbose has progress+verbosity

wyng-util-qubes

sudo wyng-util-qubes --dest qubes-ssh://wyng-wdcloud:root@Insurgo-LabRouter/mnt/Backups/nv41 --includes --dedup -wremap backup -wverbose

excerpts:

    0.0MB |  7s | vm-fedora-39-root
   31.1MB | 50% | vm-heads-tests-d12-nix-cryptsetup-private
  134.2MB |17m60| vm-heads-tests-d12-nix-cryptsetup-private
(reduced 91552.3MB)

Which gives both progress report and reduced output after work.

tlaurion commented 5 months ago

Anything, even an ellipsis, would do, but at present there is only a colon until the backup or restore is completed. I also realize I'm generalizing, but in my mind, to serve as a potential qvm-backup replacement, users should see the progress from the outset. I do realize things like --show-progress are often not there by default, but I'm thinking of the no-so-tech-savy.

Design decision is relevant to costs of producing that progress report?

tasket commented 5 months ago

@kennethrrosen @tlaurion The latest updates in Wyng and util betas are more consistent now. Unattended mode uses only a progress bar (until the end), and the util doesn't force -u for either backup or restore.

tasket commented 5 months ago

Also, it should be noted that -u is automatic in Wyng when no tty is present, such as when its run from cron or systemd.