search

taskiq-python / taskiq-redis

Broker and result backend for taskiq
MIT License
40 stars 18 forks source link

Issue with not ready result_value #37

Closed dinosaurtirex closed 1 year ago

dinosaurtirex commented 1 year ago

If value is not ready, library returns:

taskiq_result: TaskiqResult[_ReturnType] = pickle.loads(result_value)
TypeError: a bytes-like object is required, not 'NoneType'

Now it will return real error

s3rius commented 1 year ago

Can you rebase your changes onto develop?

dinosaurtirex commented 1 year ago

Looks good to me. But please rebase onto develop before merging.

Looks good to me. But please rebase onto develop before merging.

Yea of course, sorry for bit misunderstanding by my side. i will do it tomorrow. Also i guess may be to add new exception for this case? Or built in LookupError is fine?

s3rius commented 1 year ago

Thank you very much. Built-in lookup should be fine.

dinosaurtirex commented 1 year ago

Thank you very much. Built-in lookup should be fine.

Just check it out and see that it already implemented in develop branch, so just closing PR. Thanks for good library and your time!