Closed stinovlas closed 9 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
09e835e
) 96.31% compared to head (7cfb6f7
) 96.31%.
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Seems good for me.
Closes #53.
I decided not to add
timeout
argument at the moment, because any unknown argument passed to constructor is passed to theBlockedConnectionPool
(includingtimeout
if user wishes to customize it).BlockingConnectionPool
default is 20 seconds. If you think it's too high, we can still customize that value without changing constructors themselves, like this:TODO
ConnectionPool
withBlockingConnectionPool
connection_kwargs
(and max connections) to result backends