taskiq-python / taskiq-redis

Broker and result backend for taskiq
MIT License
40 stars 18 forks source link

Use blocking connection pool #54

Closed stinovlas closed 9 months ago

stinovlas commented 9 months ago

Closes #53.

I decided not to add timeout argument at the moment, because any unknown argument passed to constructor is passed to the BlockedConnectionPool (including timeout if user wishes to customize it).

BlockingConnectionPool default is 20 seconds. If you think it's too high, we can still customize that value without changing constructors themselves, like this:

if "timeout" not in connection_kwargs:
    connection_kwargs["timeout"] = 3  # or other sensible default

TODO

codecov-commenter commented 9 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (09e835e) 96.31% compared to head (7cfb6f7) 96.31%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #54 +/- ## ======================================== Coverage 96.31% 96.31% ======================================== Files 7 7 Lines 217 217 ======================================== Hits 209 209 Misses 8 8 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

s3rius commented 9 months ago

Seems good for me.