search

taskiq-python / taskiq-redis

Broker and result backend for taskiq
MIT License
40 stars 18 forks source link

Added redis sentinel support #55

Closed DABND19 closed 5 months ago

DABND19 commented 7 months ago

@s3rius Hello Pavel! I have added redis sentinel support to the taskiq-redis driver. The changes are backward compatible, but perhaps it could have been done more simply, as, for example, in dramatiq: https://github.com/Bogdanp/dramatiq/blob/master/dramatiq/brokers/redis.py#L99. But, as I understand it, the implementation of interaction with redis-py is specifically hidden in taskiq-redis.

s3rius commented 7 months ago

Thanks for your PR.

But, as I understand it, the implementation of interaction with redis-py is specifically hidden in taskiq-redis.

You are correct, users should not bother themself with details.

DABND19 commented 6 months ago

@s3rius Hello. All issues have been resolved. Can you approve the PR? And then merge it to the develop branch when you need it.

s3rius commented 5 months ago

Thank you very-very much for your work. And sorry for such a delay.

Amazing work.