Closed s3rius closed 5 months ago
Attention: 3 lines
in your changes are missing coverage. Please review.
Comparison is base (
11bebcc
) 77.20% compared to head (9d0326a
) 77.75%.
Files | Patch % | Lines |
---|---|---|
taskiq/labels.py | 88.00% | 3 Missing :warning: |
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@asvetlov, mind taking a look at the request? I'd be very grateful, since this functionality affects your PR as well.
Thanks in advance.
This problem was highlighted by @asvetlov in the https://github.com/taskiq-python/taskiq-pipelines/pull/14.
I was thinking about possible APIs for implementation this functionality and came up with this one. Now, along with dict of labels we store dict of labels types. To minimize amount of space for this information I've chosen to use ints over anything else. This solution is not perfect, but it's the most elegant solution I could come up with.
Possible improvements for the future:
parse_labels
method fromTaskiqMessage
and move it somewhere else (possibly in formatters)This request should be backward compatible, but might brake some custom middlewares.