taskiq-python / taskiq

Distributed task queue with full async support
MIT License
694 stars 44 forks source link

Update task patterns #257

Closed stinovlas closed 7 months ago

stinovlas commented 7 months ago

Closes #256.

As per #256, i changed the rglob pattern search to glob and added a possibility to specify --tasks-pattern option multiple times.

codecov-commenter commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (11bebcc) 77.20% compared to head (e8a9d07) 77.31%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #257 +/- ## =========================================== + Coverage 77.20% 77.31% +0.11% =========================================== Files 60 60 Lines 1750 1750 =========================================== + Hits 1351 1353 +2 + Misses 399 397 -2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

s3rius commented 7 months ago

Actually I like the approach, because it will make it task searching more flexible. I will update minor version because of this PR, Since it might break apps that were using custom --tasks-pattern.

stinovlas commented 7 months ago

I still have to make some corrections in import_tasks and I'd also like to write a test for it. I'll drop the draft status when the PR is ready :-).

s3rius commented 7 months ago

Also, can you make import_tasks to accept either sequence or string as pattern? Because I was using this function in some taskiq-related third-party libs.

stinovlas commented 7 months ago

Also, can you make import_tasks to accept either sequence or string as pattern? Because I was using this function in some taskiq-related third-party libs.

Sure, done :-). I added some tests and believe that the PR is ready for review.

s3rius commented 7 months ago

Thank you very much for your contributions.