New Behat Plugin

[KashifSaadat]

Hey,

I've the need for a Behat Plugin, working similar to how your PHPUnit Plugin has been implemented for use with my Behat Tasks. This should have the ability to take a list of command line arguments and execute them within the same Task process.

Cheers,

Kash

[KashifSaadat]

https://github.com/KashifSaadat/task-behat

[aranw]

Ah very nice, thanks for contributing :+1: :smile:

[KashifSaadat]

:D

[mbfisher]

Sorry for the slow response on this, will have some feedback tonight.

M

[mbfisher]

Looks great!

Defo done the right thing going with ArgvInput for the time being; I've had a further look at integrating with Behat's Application and it's pretty gnarly. The Command::add method covers off new arguments that are added to Behat before the plugin is updated, which I don't think will be very common.

A couple of notes, of course IMHO:

• On the Command class method names, I would use set* for options with values e.g.

setSuite('foo') # --suite foo

but not for positional arguments or VALUE_NONE options, as you've done with

appendSnippets # --append-snippets

I'd do the same for useColor, useStrict, stopOnFailure etc.

• I'd split the DirectoryManager into its own package with some integration tests. kash/cd perhaps?
• I don't think you can assert that collaborator methods are called in a set order with PhpSpec, which would improve the example dealing with changing to a working directory, but I've tweeted asking for advice to check.
• Finally, and most importantly, it needs a README with examples, installation instructions, and API documentation.

Then we'll need to figure out a process for adopting plugins into the task vendor!

@aranw, got any thoughts?

Thanks again for contributing!

M

[KashifSaadat]

Awesome cheers for the feedback!

When I get some time I'll make a few revisions and update here.

[KashifSaadat]

I've now made the suggested updates. Apologies for the README, it is a bit pants currently. :O