search

taskrabbit / react-native-zendesk-chat

React Native Wrapper around Zendesk Chat v2
MIT License
130 stars 128 forks source link

[iOS] Archive Failed #70

Closed padupuy closed 4 years ago

padupuy commented 4 years ago

Hi @fbartho This library is exactly what I was looking for to integrate Zendesk Chat V2 in my App ❤️ !
In dev mode everything works fine, unfortunately when I try to build an iOS release, the archive failed, here is the log : 

The following build commands failed:
    PhaseScriptExecution [CP]\ Embed\ Pods\ Frameworks /Users/pax/Library/Developer/Xcode/DerivedData/MyProduct-ewouwhypkycamggxraskzrjneljg/Build/Intermediates.noindex/ArchiveIntermediates/MyProduct-Staging/IntermediateBuildFilesPath/MyProduct.build/Release-iphoneos/MyProduct.build/Script-6439D71AABAE32D52EC1D8F6.sh
(1 failure)
[16:13:37]: Exit status: 65

+---------------+-------------------------+
|            Build environment            |
+---------------+-------------------------+
| xcode_path    | /Applications/Xcode.app |
| gym_version   | 2.156.1                 |
| export_method | ad-hoc                  |
| sdk           | iPhoneOS13.6.sdk        |
+---------------+-------------------------+

[16:13:37]: ▸ Stripped /Users/pax/Library/Developer/Xcode/DerivedData/MyProduct-ewouwhypkycamggxraskzrjneljg/Build/Intermediates.noindex/ArchiveIntermediates/MyProduct-Staging/InstallationBuildProductsLocation/Applications/MyProduct - staging.app/Frameworks/ChatProvidersSDK.framework/ChatProvidersSDK of architectures: x86_64 i386
[16:13:37]: ▸ Code Signing /Users/pax/Library/Developer/Xcode/DerivedData/MyProduct-ewouwhypkycamggxraskzrjneljg/Build/Intermediates.noindex/ArchiveIntermediates/MyProduct-Staging/InstallationBuildProductsLocation/Applications/MyProduct - staging.app/Frameworks/ChatProvidersSDK.framework with Identity Apple Distribution: XXXX (XXXXXXXXXX)
[16:13:37]: ▸ /usr/bin/codesign --force --sign XXXX  --preserve-metadata=identifier,entitlements '/Users/pax/Library/Developer/Xcode/DerivedData/MyProduct-ewouwhypkycamggxraskzrjneljg/Build/Intermediates.noindex/ArchiveIntermediates/MyProduct-Staging/InstallationBuildProductsLocation/Applications/MyProduct - staging.app/Frameworks/ChatProvidersSDK.framework'
[16:13:37]: ▸ /Users/pax/xxx/MyProduct/ios/Pods/Target Support Files/Pods-MyProduct/Pods-MyProduct-frameworks.sh: eval: line 133: unexpected EOF while looking for matching `''
[16:13:37]: ▸ Command PhaseScriptExecution failed with a nonzero exit code

I follow the Zendesk SDK Official documentation, so I put the additionnal "Run Script Phase" add the end of the Build Phases:
"${BUILT_PRODUCTS_DIR}/${FRAMEWORKS_FOLDER_PATH}/ChatSDK.framework/strip-frameworks.sh"

The error occured in the step before "[CP] Embed Pods Frameworks", so do I need to put the "Strip slices from fat frameworks" run script before ? I tried but without success ..

any idea ?

fbartho commented 4 years ago

What versions of Xcode and react-native are you using?

Also, I see you have a -Staging on your product. How are you generating those schemes?

padupuy commented 4 years ago

Xcode : 11.6 (11E708) React Native : 0.62.2

I build my app with Fastlane, the scheme Staging is a copy of my Release scheme, only the env var are different

fbartho commented 4 years ago

That should be a fine combination of Xcode/RN Versions.

I can't provide much support for Fastlane -- I've fought them a tooling issues over the years, and stopped using them 3 years ago.

I've found many problems with custom-schemes + react-native (with native libraries):

Additionally, have you inspected the build-script at that line number?

[16:13:37]: ▸ /Users/pax/xxx/MyProduct/ios/Pods/Target Support Files/Pods-MyProduct/Pods-MyProduct-frameworks.sh: eval: line 133: unexpected EOF while looking for matching `''

Maybe that can give you a hint at what's failing?

padupuy commented 4 years ago

🤔 I use Staging scheme and Release scheme for a while without any trouble.
Fastlane is also a powerful tool to build and ship ios (or android) apps

So, I add this library on a branch, and then the build failure occured.

Here is the content of the "Pods-MyProduct-framework.sh" file

#!/bin/sh
set -e
set -u
set -o pipefail

function on_error {
  echo "$(realpath -mq "${0}"):$1: error: Unexpected failure"
}
trap 'on_error $LINENO' ERR

if [ -z ${FRAMEWORKS_FOLDER_PATH+x} ]; then
  # If FRAMEWORKS_FOLDER_PATH is not set, then there's nowhere for us to copy
  # frameworks to, so exit 0 (signalling the script phase was successful).
  exit 0
fi

echo "mkdir -p ${CONFIGURATION_BUILD_DIR}/${FRAMEWORKS_FOLDER_PATH}"
mkdir -p "${CONFIGURATION_BUILD_DIR}/${FRAMEWORKS_FOLDER_PATH}"

COCOAPODS_PARALLEL_CODE_SIGN="${COCOAPODS_PARALLEL_CODE_SIGN:-false}"
SWIFT_STDLIB_PATH="${DT_TOOLCHAIN_DIR}/usr/lib/swift/${PLATFORM_NAME}"

# Used as a return value for each invocation of `strip_invalid_archs` function.
STRIP_BINARY_RETVAL=0

# This protects against multiple targets copying the same framework dependency at the same time. The solution
# was originally proposed here: https://lists.samba.org/archive/rsync/2008-February/020158.html
RSYNC_PROTECT_TMP_FILES=(--filter "P .*.??????")

# Copies and strips a vendored framework
install_framework()
{
  if [ -r "${BUILT_PRODUCTS_DIR}/$1" ]; then
    local source="${BUILT_PRODUCTS_DIR}/$1"
  elif [ -r "${BUILT_PRODUCTS_DIR}/$(basename "$1")" ]; then
    local source="${BUILT_PRODUCTS_DIR}/$(basename "$1")"
  elif [ -r "$1" ]; then
    local source="$1"
  fi

  local destination="${TARGET_BUILD_DIR}/${FRAMEWORKS_FOLDER_PATH}"

  if [ -L "${source}" ]; then
    echo "Symlinked..."
    source="$(readlink "${source}")"
  fi

  # Use filter instead of exclude so missing patterns don't throw errors.
  echo "rsync --delete -av "${RSYNC_PROTECT_TMP_FILES[@]}" --links --filter \"- CVS/\" --filter \"- .svn/\" --filter \"- .git/\" --filter \"- .hg/\" --filter \"- Headers\" --filter \"- PrivateHeaders\" --filter \"- Modules\" \"${source}\" \"${destination}\""
  rsync --delete -av "${RSYNC_PROTECT_TMP_FILES[@]}" --links --filter "- CVS/" --filter "- .svn/" --filter "- .git/" --filter "- .hg/" --filter "- Headers" --filter "- PrivateHeaders" --filter "- Modules" "${source}" "${destination}"

  local basename
  basename="$(basename -s .framework "$1")"
  binary="${destination}/${basename}.framework/${basename}"

  if ! [ -r "$binary" ]; then
    binary="${destination}/${basename}"
  elif [ -L "${binary}" ]; then
    echo "Destination binary is symlinked..."
    dirname="$(dirname "${binary}")"
    binary="${dirname}/$(readlink "${binary}")"
  fi

  # Strip invalid architectures so "fat" simulator / device frameworks work on device
  if [[ "$(file "$binary")" == *"dynamically linked shared library"* ]]; then
    strip_invalid_archs "$binary"
  fi

  # Resign the code if required by the build settings to avoid unstable apps
  code_sign_if_enabled "${destination}/$(basename "$1")"

  # Embed linked Swift runtime libraries. No longer necessary as of Xcode 7.
  if [ "${XCODE_VERSION_MAJOR}" -lt 7 ]; then
    local swift_runtime_libs
    swift_runtime_libs=$(xcrun otool -LX "$binary" | grep --color=never @rpath/libswift | sed -E s/@rpath\\/\(.+dylib\).*/\\1/g | uniq -u)
    for lib in $swift_runtime_libs; do
      echo "rsync -auv \"${SWIFT_STDLIB_PATH}/${lib}\" \"${destination}\""
      rsync -auv "${SWIFT_STDLIB_PATH}/${lib}" "${destination}"
      code_sign_if_enabled "${destination}/${lib}"
    done
  fi
}

# Copies and strips a vendored dSYM
install_dsym() {
  local source="$1"
  warn_missing_arch=${2:-true}
  if [ -r "$source" ]; then
    # Copy the dSYM into the targets temp dir.
    echo "rsync --delete -av "${RSYNC_PROTECT_TMP_FILES[@]}" --filter \"- CVS/\" --filter \"- .svn/\" --filter \"- .git/\" --filter \"- .hg/\" --filter \"- Headers\" --filter \"- PrivateHeaders\" --filter \"- Modules\" \"${source}\" \"${DERIVED_FILES_DIR}\""
    rsync --delete -av "${RSYNC_PROTECT_TMP_FILES[@]}" --filter "- CVS/" --filter "- .svn/" --filter "- .git/" --filter "- .hg/" --filter "- Headers" --filter "- PrivateHeaders" --filter "- Modules" "${source}" "${DERIVED_FILES_DIR}"

    local basename
    basename="$(basename -s .dSYM "$source")"
    binary_name="$(ls "$source/Contents/Resources/DWARF")"
    binary="${DERIVED_FILES_DIR}/${basename}.dSYM/Contents/Resources/DWARF/${binary_name}"

    # Strip invalid architectures so "fat" simulator / device frameworks work on device
    if [[ "$(file "$binary")" == *"Mach-O "*"dSYM companion"* ]]; then
      strip_invalid_archs "$binary" "$warn_missing_arch"
    fi

    if [[ $STRIP_BINARY_RETVAL == 1 ]]; then
      # Move the stripped file into its final destination.
      echo "rsync --delete -av "${RSYNC_PROTECT_TMP_FILES[@]}" --links --filter \"- CVS/\" --filter \"- .svn/\" --filter \"- .git/\" --filter \"- .hg/\" --filter \"- Headers\" --filter \"- PrivateHeaders\" --filter \"- Modules\" \"${DERIVED_FILES_DIR}/${basename}.framework.dSYM\" \"${DWARF_DSYM_FOLDER_PATH}\""
      rsync --delete -av "${RSYNC_PROTECT_TMP_FILES[@]}" --links --filter "- CVS/" --filter "- .svn/" --filter "- .git/" --filter "- .hg/" --filter "- Headers" --filter "- PrivateHeaders" --filter "- Modules" "${DERIVED_FILES_DIR}/${basename}.dSYM" "${DWARF_DSYM_FOLDER_PATH}"
    else
      # The dSYM was not stripped at all, in this case touch a fake folder so the input/output paths from Xcode do not reexecute this script because the file is missing.
      touch "${DWARF_DSYM_FOLDER_PATH}/${basename}.dSYM"
    fi
  fi
}

# Copies the bcsymbolmap files of a vendored framework
install_bcsymbolmap() {
    local bcsymbolmap_path="$1"
    local destination="${BUILT_PRODUCTS_DIR}"
    echo "rsync --delete -av "${RSYNC_PROTECT_TMP_FILES[@]}" --filter "- CVS/" --filter "- .svn/" --filter "- .git/" --filter "- .hg/" --filter "- Headers" --filter "- PrivateHeaders" --filter "- Modules" "${bcsymbolmap_path}" "${destination}""
    rsync --delete -av "${RSYNC_PROTECT_TMP_FILES[@]}" --filter "- CVS/" --filter "- .svn/" --filter "- .git/" --filter "- .hg/" --filter "- Headers" --filter "- PrivateHeaders" --filter "- Modules" "${bcsymbolmap_path}" "${destination}"
}

# Signs a framework with the provided identity
code_sign_if_enabled() {
  if [ -n "${EXPANDED_CODE_SIGN_IDENTITY:-}" -a "${CODE_SIGNING_REQUIRED:-}" != "NO" -a "${CODE_SIGNING_ALLOWED}" != "NO" ]; then
    # Use the current code_sign_identity
    echo "Code Signing $1 with Identity ${EXPANDED_CODE_SIGN_IDENTITY_NAME}"
    local code_sign_cmd="/usr/bin/codesign --force --sign ${EXPANDED_CODE_SIGN_IDENTITY} ${OTHER_CODE_SIGN_FLAGS:-} --preserve-metadata=identifier,entitlements '$1'"

    if [ "${COCOAPODS_PARALLEL_CODE_SIGN}" == "true" ]; then
      code_sign_cmd="$code_sign_cmd &"
    fi
    echo "$code_sign_cmd"
    eval "$code_sign_cmd"
  fi
}

# Strip invalid architectures
strip_invalid_archs() {
  binary="$1"
  warn_missing_arch=${2:-true}
  # Get architectures for current target binary
  binary_archs="$(lipo -info "$binary" | rev | cut -d ':' -f1 | awk '{$1=$1;print}' | rev)"
  # Intersect them with the architectures we are building for
  intersected_archs="$(echo ${ARCHS[@]} ${binary_archs[@]} | tr ' ' '\n' | sort | uniq -d)"
  # If there are no archs supported by this binary then warn the user
  if [[ -z "$intersected_archs" ]]; then
    if [[ "$warn_missing_arch" == "true" ]]; then
      echo "warning: [CP] Vendored binary '$binary' contains architectures ($binary_archs) none of which match the current build architectures ($ARCHS)."
    fi
    STRIP_BINARY_RETVAL=0
    return
  fi
  stripped=""
  for arch in $binary_archs; do
    if ! [[ "${ARCHS}" == *"$arch"* ]]; then
      # Strip non-valid architectures in-place
      lipo -remove "$arch" -output "$binary" "$binary"
      stripped="$stripped $arch"
    fi
  done
  if [[ "$stripped" ]]; then
    echo "Stripped $binary of architectures:$stripped"
  fi
  STRIP_BINARY_RETVAL=1
}

install_artifact() {
  artifact="$1"
  base="$(basename "$artifact")"
  case $base in
  *.framework)
    install_framework "$artifact"
    ;;
  *.dSYM)
    # Suppress arch warnings since XCFrameworks will include many dSYM files
    install_dsym "$artifact" "false"
    ;;
  *.bcsymbolmap)
    install_bcsymbolmap "$artifact"
    ;;
  *)
    echo "error: Unrecognized artifact "$artifact""
    ;;
  esac
}

copy_artifacts() {
  file_list="$1"
  while read artifact; do
    install_artifact "$artifact"
  done <$file_list
}

ARTIFACT_LIST_FILE="${BUILT_PRODUCTS_DIR}/cocoapods-artifacts-${CONFIGURATION}.txt"
if [ -r "${ARTIFACT_LIST_FILE}" ]; then
  copy_artifacts "${ARTIFACT_LIST_FILE}"
fi

if [[ "$CONFIGURATION" == "Debug" ]]; then
  install_framework "${PODS_ROOT}/ZendeskChatProvidersSDK/ChatProvidersSDK.framework"
  install_dsym "${PODS_ROOT}/ZendeskChatProvidersSDK/ChatProvidersSDK.framework.dSYM"
  install_framework "${PODS_ROOT}/ZendeskChatSDK/ChatSDK.framework"
  install_dsym "${PODS_ROOT}/ZendeskChatSDK/ChatSDK.framework.dSYM"
  install_framework "${PODS_ROOT}/ZendeskCommonUISDK/CommonUISDK.framework"
  install_dsym "${PODS_ROOT}/ZendeskCommonUISDK/CommonUISDK.framework.dSYM"
  install_framework "${PODS_ROOT}/ZendeskMessagingAPISDK/MessagingAPI.framework"
  install_framework "${PODS_ROOT}/ZendeskMessagingSDK/MessagingSDK.framework"
  install_dsym "${PODS_ROOT}/ZendeskMessagingSDK/MessagingSDK.framework.dSYM"
  install_framework "${PODS_ROOT}/ZendeskSDKConfigurationsSDK/SDKConfigurations.framework"
  install_dsym "${PODS_ROOT}/ZendeskSDKConfigurationsSDK/SDKConfigurations.framework.dSYM"
fi
if [[ "$CONFIGURATION" == "Release" ]]; then
  install_framework "${PODS_ROOT}/ZendeskChatProvidersSDK/ChatProvidersSDK.framework"
  install_dsym "${PODS_ROOT}/ZendeskChatProvidersSDK/ChatProvidersSDK.framework.dSYM"
  install_framework "${PODS_ROOT}/ZendeskChatSDK/ChatSDK.framework"
  install_dsym "${PODS_ROOT}/ZendeskChatSDK/ChatSDK.framework.dSYM"
  install_framework "${PODS_ROOT}/ZendeskCommonUISDK/CommonUISDK.framework"
  install_dsym "${PODS_ROOT}/ZendeskCommonUISDK/CommonUISDK.framework.dSYM"
  install_framework "${PODS_ROOT}/ZendeskMessagingAPISDK/MessagingAPI.framework"
  install_framework "${PODS_ROOT}/ZendeskMessagingSDK/MessagingSDK.framework"
  install_dsym "${PODS_ROOT}/ZendeskMessagingSDK/MessagingSDK.framework.dSYM"
  install_framework "${PODS_ROOT}/ZendeskSDKConfigurationsSDK/SDKConfigurations.framework"
  install_dsym "${PODS_ROOT}/ZendeskSDKConfigurationsSDK/SDKConfigurations.framework.dSYM"
fi
if [ "${COCOAPODS_PARALLEL_CODE_SIGN}" == "true" ]; then
  wait
fi

L133 is : eval "$code_sign_cmd" in the code_sign_if_enabled() func

padupuy commented 4 years ago

@fbartho ok I think about something ... "MyProduct" is not the real name of my project, the real name contains a ' (single quote) and I just found some related issues in SO and cocoapods repo ... Thanks for you help and sorry for the trouble ... Thanks again for your lib ✌️

fbartho commented 4 years ago

That’s exactly what I had a suspicion about!

Shell scripts often explode if you have unexpected symbols — especially in filenames. So I was looking for spaces, quotes, ampersands, and slashes (or even more wacky: emoji).

Glad you figured it out!