tasks / tasks

Bringing Astrid Tasks back from the dead
http://tasks.org
GNU General Public License v3.0
3.67k stars 505 forks source link

Replace Mapbox tiles with OpenStreetMap tiles #922

Closed LucasDondo closed 3 years ago

LucasDondo commented 4 years ago

Add OSM for all the UnGoogled users. I know there is the option of MapBox, but it is useless in most cases.

abaker commented 4 years ago

Is it the MapBox tiles or geocoding service that you want to replace?

LucasDondo commented 4 years ago

Is it the MapBox tiles or geocoding service that you want to replace?

I didn't mean replacing, just adding OpenStreetMaps (Sorry if I didn't specified). Adding it to both the Search Provider and Map Provider.

baditaflorin commented 4 years ago

I think he is reffering to add another overlay to the map, but with a basemap of OpenStreetMap. Or have a icon where you can cha ve the image overlay, either as a select menu or just a 2 way switch between the 2 image tile overlays. If you have raster. It can be done in mapbox something like this

"The Mapbox Maps SDK for Android comes bundled with a handful of map styles. You can find a list of the current bundled styles with constants found in the Maps SDK's Style class. In this example, you'll use a Mapbox-designed style, which isn't included in the Mapbox Maps SDK for Android.

You must set the map style programmatically using the MapboxMap class' setStyle(); method. The method requires a Style object, which can be created via a URL. Once it's created via a URL, various images, sources, and layers can be added to the Style." https://docs.mapbox.com/help/tutorials/first-steps-android-sdk/

abaker commented 4 years ago

I'm actually on the hunt for a Mapbox tile replacement. They announced a couple days ago that their map renderer is changing to a non-free license (more on the F-Droid forum), so the F-Droid build is now stuck on a pre-androidx release of the SDK from August 2019

I didn't see a point of offering a choice between two non-free mapping options, and the Mapbox SDK is a significant portion of Tasks' APK size, so the next Play Store release will only support Google Maps.

baditaflorin commented 4 years ago

I have not used it, but if you are looking for a java implementation this could help. https://github.com/osmdroid/osmdroid

Mapbox is based on Leaflet, so another version where you would thread the map as a WebView and use javascript (probably not native and need to check speed)

nunesgh commented 3 years ago

@abaker, Mapbox is still available under Settings -> Look and feel -> Location -> Search provider, even though it is not available anymore --selecting it does not actually change anything.

abaker commented 3 years ago

Map tiles and place search are actually two separate features. Google Play users can only use Google Maps tiles, but they can choose between Mapbox search and Google Places search. Google Places search is only available to subscribers because it costs money. Mapbox offers much higher limits for their free tier

nunesgh commented 3 years ago

@abaker, thanks for clarifying. I was not aware of that.

abaker commented 3 years ago

Replaced Mapbox tiles with OSM tiles in b0777101e8d606ba97b7c942cb9595c2f8b785aa