blakadder
commented
4 years ago Thanks for the fix!
The container was removed from the original source since it was outdated and its harder to maintain inside the main code.
I wasn't really focusing on the flag override capabilites with entrypoint.sh, nor did I really test them since I use the bash script to choose builds or copy custom user_config. I don't think I changed anything in the entrypoint.sh script so no author information was erased.
Support is secured for the time being since a docker container is how I build my binaries for my local OTA server
my_user_config.h is processed before the generated user_config_override.h so all options and flags are already set. The created override file checks with ifndef if a option/flag but because these are all set by my_user_config.h none of paramerters provided to docker will have any effect on the build. Options and flags should use undef to remove the option and use define to set the option passed as an environment variable to the docker container.
It is nice to see that my Container was moved and not just deleted, also thank you for updating the Dockerfile so it can build the current tasmota development branch. I also removed some lines (leftover comments from my original script).
I would have left at least the original author of the scripts and container in the files, but this is just my opinion.
I hope you will support the docker build and update the container for future releases.