tasoc / photometry

The TASOC Photometry Pipeline
https://tasoc.dk
GNU General Public License v3.0
18 stars 4 forks source link

New output FITS file naming scheme #20

Closed rhandberg closed 3 years ago

rhandberg commented 4 years ago

This PR will change the structure of the file-names output by the photometry to include the TESS camera and CCD in the name.

The issues addressed by this PR are:

  1. Avoid duplicate filenames in cases of targets that are observed in overlapping cameras.
  2. Enforce unique lightcurves in TODO-file (related to 1).
  3. Ensure that naming scheme would work for 8+ years of TESS operation (sectors > 99).
  4. Remove duplicate information in TODO-file (starid).
  5. Fix issues with targets in overlapping regions potentially marking targets on the other CCD as SKIPPED.
codecov[bot] commented 4 years ago

Codecov Report

Merging #20 into devel will increase coverage by 0.39%. The diff coverage is 95.91%.

Impacted file tree graph

@@            Coverage Diff             @@
##            devel      #20      +/-   ##
==========================================
+ Coverage   80.27%   80.66%   +0.39%     
==========================================
  Files          27       25       -2     
  Lines        3619     3594      -25     
==========================================
- Hits         2905     2899       -6     
+ Misses        714      695      -19     
Impacted Files Coverage Δ
photometry/taskmanager.py 93.18% <85.71%> (+8.53%) :arrow_up:
photometry/BasePhotometry.py 94.30% <100.00%> (-0.03%) :arrow_down:
photometry/todolist.py 84.72% <100.00%> (ø)
photometry/utilities.py 76.20% <100.00%> (+0.79%) :arrow_up:
photometry/prepare.py 85.05% <0.00%> (-0.17%) :arrow_down:
photometry/image_motion.py 94.51% <0.00%> (ø)
photometry/fixes/time_offset.py
photometry/fixes/__init__.py
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8809ae3...339f548. Read the comment docs.