Handles emojis in tweet texts

taspinar / twitterscraper

Scrape Twitter for Tweets

MIT License

2.4k stars 581 forks source link

Handles emojis in tweet texts #211

Closed rezemika closed 4 years ago

rezemika commented 5 years ago

This small PR improves the handling of tweets containing emojis (now their unicode is integrated in tweet.text). It's probably possible to do this better however, I'd appreciate any feedback (I had some troubles with encoding...)! :)

aditya-malte commented 4 years ago

Any updates regarding this? I think this is an important PR

rezemika commented 4 years ago

I don't know... I can rebase the branch on dev if @taspinar is willing to merge it.

aditya-malte commented 4 years ago

@taspinar , this is an important addition as emojis play an important role on twitter. It would be great if you could review the code and merge accordingly Thanks

taspinar commented 4 years ago

Is this MR still necessary after merging #277 ?

rezemika commented 4 years ago

I don't think so, it's exactly the same PR (the commits are almost identical).