search

taspinar / twitterscraper

Scrape Twitter for Tweets
MIT License
2.39k stars 579 forks source link

Add deps required to build other deps #232

Open cmcaine opened 4 years ago

cmcaine commented 4 years ago

This increases the size of the image quite a lot.

Alternatives welcomed. Would also be nice to pin the container version so that this doesn't become stale again, but I don't know if you want to do that.

We can pin by setting FROM to python:3.7-alpine3.10.

taspinar commented 4 years ago

Same here, Is this still necessary after merging #253 ?

cmcaine commented 4 years ago

Probably not, if people are reporting success with 253.

My comment about pinning the alpine version is still relevant, tho. An alternative would be testing the dockerfile with CI, but that sounds like a lot of wasted cycles to me.