Option to disable proxying requests

taspinar / twitterscraper

Scrape Twitter for Tweets

MIT License

2.39k stars 579 forks source link

Option to disable proxying requests #234

Closed haseebelahi closed 4 years ago

haseebelahi commented 4 years ago

Fixes #222.

Add a flag named -dp or --disableproxy to disable the use of proxy servers when scrapping tweets.

taspinar commented 4 years ago

@haseebelahi This looks like an useful addition, but I think it is better to rename to argument to use_proxy and set the default value to True, instead of the way it is implemented now.

It does not look nice, to pass the negative of an argument.

hanscg commented 4 years ago

@taspinar Hi, I got a problem with proxy as well so I'm interested in this issue. If the argument is renamed to use_proxy, wouldn't it be confusing that when you set the flag for use_proxy the proxy will be disabled? It would be fine if the default value is False since activating the flag = using the proxy, but I can understand that it would be better to keep using proxy as the default behavior.