search

tass-belgium / picotcp-modules

Application level modules to run on top of the popular Embedded picoTCP TCP/IP stack
GNU General Public License v2.0
8 stars 11 forks source link

Ci lamp dev clean #13

Open SParmentier opened 7 years ago

SParmentier commented 7 years ago

@phalox Could you review this ?

SParmentier commented 7 years ago

@phalox Can you review ? I need to add some task to Jira to refactor some functions but now it's working both on our computers and on jenkins.

phalox commented 7 years ago

Phew this "pico_process_uri" function got really ugly over time. Could you rework the code? Make smaller functions out of this, get rid of magic numers/calculations of length...

SParmentier commented 7 years ago

I'm not really sure to have the time to refactor all the function right now because we'll do a demo now and it's my last afternoon before going to Barco. So I'll make a task on jira ?

phalox commented 7 years ago

Sure! :-) Or maybe on github in this repository ( @frederikvs where do you think such a ticket belongs?) For this it could also be nice that we start following up the quality of the modules.