search

tassaron / dnd-character

library for making Dungeons & Dragons 5e characters as serializable data
https://pypi.org/project/dnd-character/
Eclipse Public License 2.0
45 stars 17 forks source link

fix applyed to experience.py tested by #2

Closed MechaCoder closed 2 years ago

MechaCoder commented 2 years ago

hi @tassaron

i hope you don't mind but i took a whack at the issue, what i found was the lru_cache, was not able to process by default, by entering the maxsize of None the Class seems to have fixed the issue, i have proved that it works with a example.py and example from the readme.md

1

stephenmm commented 2 years ago

This fix resolved the problem for me as well.

MechaCoder commented 2 years ago

thanks @stephenmm,

tassaron commented 2 years ago

I'm sorry I've hesitated to merge this because I can't personally recreate the problem, although I can't foresee any problem from changing this decorator. Thank you.

Curious what version of Python and what OS you are running?

MechaCoder commented 2 years ago

I was on Ubuntu using python 3.7, thank you again for creating the library