tassaron / dnd-character

library for making Dungeons & Dragons 5e characters as serializable data
https://pypi.org/project/dnd-character/
Eclipse Public License 2.0
45 stars 17 forks source link

Inconsistent use of camelCase and snake_case #5

Closed tassaron closed 1 year ago

tassaron commented 2 years ago

This library uses mainly camelCase for method names and mainly snake_case for attributes, but it's inconsistent. This happened because I was transitioning to using snake_case in Python while originally writing this code.

I believe all methods and attributes should be changed to snake_case. Python itself isn't consistent about this, so camelCase is fine too and might be a simpler change. I don't care either way, as long as it's consistent :)