PropertyCross implementation using OnsenUI.

[argelius]

Hi,

@ColinEberhardt Suggested adding OnsenUI to the PropertyCross site.

I've made a simple implementation of the PropertyCross application using OnsenUI.

I wasn't really sure how to submit the implementation so the pull request only contains the www folder. If you would like me to add something I will gladly do it.

It runnable by just serving the www folder.

OnsenUI works on Android 2.3+ and iOS6+ but not on Windows phones.

[ColinEberhardt]

Thanks for this submission, much appreciated. I'll review it shortly!

[argelius]

Thanks Colin! 2014/11/13 2:27 "Colin Eberhardt" notifications@github.com:

Thanks for this submission, much appreciated. I'll review it shortly!

— Reply to this email directly or view it on GitHub https://github.com/tastejs/PropertyCross/pull/296#issuecomment-62756976.

[argelius]

@ColinEberhardt Did you look at it?

[ColinEberhardt]

Hi @argelius - really sorry it has taken so long to get back to you on this.

I've had a look at your pull request, and it looks really good. I've started the process of adding this implementation to the PropertyCross website:

https://github.com/ColinEberhardt/PropertyCross-Site/commit/ea556109820c1468f1633f11a39465030628d3e5

Before I go ahead and add it, there are a few bugs you might want to take a look at:

• The 'My Location' search produces an item in the search history that looks a bit messy, I'd suggest rounding the lat / long values to two decimal places
• If the search returns an ambiguous result, it is still added to the search history. Only searches that return a list of properties should be added.

Both very minor points.

One other thing - can you please add a README file? See the following as a good example:

https://github.com/tastejs/PropertyCross/blob/master/intelappframework/README.md

You should include an Overview section, summarizing the framework in a few paragraphs. This is used directly on the website, so please keep it fact-based. Also an Application Structure is really helpful for people who are browsing the code. Feel free to add anything else you think might help people understand your code!

Once these minor changes are made, I'll sort out the PhoneGap Build and get this merged.

Thanks again.

[argelius]

Thanks @ColinEberhardt ,

I've fixed the issues and added a short README.md file. I'm sorry for all the commits, would you like me to squash them into one big commit or is this OK?

[ColinEberhardt]

Great - thanks for the update. Merging this in, will update the website shortly.

Thanks again for the contribution :-)

[masahirotanaka]

Hope you guys update the Website and add Onsen UI soon!

[ColinEberhardt]

Just updated it :-)

[masahirotanaka]

Thank you!