search

tastejs / PropertyCross

Helping developers select a framework for cross-platform mobile development.
propertycross.com
591 stars 215 forks source link

Update jquery mobile #312

Closed matthewdunsdon closed 9 years ago

matthewdunsdon commented 9 years ago

Relates to #310

ColinEberhardt commented 9 years ago

Nice work - just tried this out and it works great :-)

Probably just needs the README updating and then its ready to merge.

arthurvr commented 9 years ago

Sorry for the nitpicks ;) nice work!

ColinEberhardt commented 9 years ago

Sorry for the nitpicks ;) nice work!

Thanks @arthurvr - any additional reviews are welcome :-)

matthewdunsdon commented 9 years ago

@ColinEberhardt Are there any outstanding issues on this pull request?

The README file has been cleaned up to reflect the changes made to the project (i.e. the move to using the default theme).

matthewdunsdon commented 9 years ago

One outstanding issue is the JQueryMobile assets, which are using an old JQueryMobile logo. Should this be fixed as par of this PR?

It is worth noting, the website PR includes an update to the JQueryMobile logo (https://github.com/matthewdunsdon/PropertyCross-Site/commit/f5254b66b90a8a0e6609121650468be003989ed1)

ColinEberhardt commented 9 years ago

Great stuff - while you are working in this area, it would be great if you could update the logo too. I'll merge immediately after you do that.

Thanks for contributing :-)

matthewdunsdon commented 9 years ago

Updated JQueryMobile icons

ColinEberhardt commented 9 years ago

Awesome - thanks. I'll take a look at your 'site' PR next