search

tastejs / TasteMusic

Empowering your MDD (Music Driven Development) - Music recommendations by JavaScripters
https://github.com/tastejs/TasteMusic/issues/1
178 stars 13 forks source link

Foundation update #13

Closed Glavin001 closed 10 years ago

Glavin001 commented 10 years ago

Tasks:

Click a track from the list to play it!

Glavin001 commented 10 years ago
Glavin001 commented 10 years ago

Thank you for going over my commits, @sindresorhus. Is there anything else you notice that should be amended before merging?

Glavin001 commented 10 years ago
sindresorhus commented 10 years ago

Discuss: should Travis CI test include jshint?

Yes

Glavin001 commented 10 years ago

Discuss: should Travis CI test include jshint?

Yes

This is what I originally had by using grunt default as npm test. See comment on issue #11 for details.

I can either change back to what I had: npm test => grunt default, or add another Grunt subtask to test for jshint.

sindresorhus commented 10 years ago

@Glavin001 what you had was fine. I was just thrown off by the grunt default usage, which is moot since grunt does the same thing.

Glavin001 commented 10 years ago

I was just thrown off by the grunt default usage, which is moot since grunt does the same thing.

I wanted to be explicit that it was the default task (maybe for Grunt first comers reading the source code, etc) since it would make more sense to be grunt test, however it is not in this case.

@Glavin001 what you had was fine.

I'll change to npm test => grunt.

sindresorhus commented 10 years ago

Awesome stuff :)