tastejs / hacker-news-pwas

HNPWA - Hacker News readers as Progressive Web Apps 📱
https://hnpwa.com
2.38k stars 206 forks source link

create-react-app example is nonoptimal #137

Closed stereobooster closed 6 years ago

stereobooster commented 6 years ago

Hi. I checked given example with https://www.webpagetest.org (From: Dulles, VA - Moto G4 - Chrome - 3G). I'm talking about stephenkingsley/hackerNews-pwa.

https://www.webpagetest.org/result/180130_XR_657329befdfcd07c1712592b7455e092/

waterfall

filmstrip

I fixed some issues in round-1:

https://www.webpagetest.org/result/180130_HR_894b9a821e6b53d0f4e2369fa00abfb3/

waterfall

filmstrip

I added even more optimisation, but those changes have a lot of bugs (round-2)

https://www.webpagetest.org/result/180130_D9_369033210c83432fd7ddee829836a232/

waterfall

filmstrip

Just saying CRA can do much better (even without SSR)

housseindjirdeh commented 6 years ago

Firstly, so sorry for not responding much sooner @stereobooster. We're now getting back on track resolving issues and submissions.

This is great!! We've set some base requirements for submissions but are always looking to find performance optimizations. Have you considered submitting PRs to the repository for this submission to improve it? I'm sure the author would love to have them included.

This also looks like a great example resource of when to use react-snap (it's a great tool!). For that reason I wouldn't mind landing this improved application as a separate submission if you prefer that as well.

Will close this issue for now but please don't hesitate to let me know what you think.