tastejs / hacker-news-pwas

HNPWA - Hacker News readers as Progressive Web Apps 📱
https://hnpwa.com
2.38k stars 207 forks source link

Add pwa-starter-kit-hn #160

Open keanulee opened 6 years ago

keanulee commented 6 years ago

Demo: https://pwa-starter-kit-hn.appspot.com/

App built with the same structure as PWA Starter Kit. More details in the commit.

kristoferbaxter commented 6 years ago

Hmm. Something is a bit off with the results here.

screen shot 2018-07-25 at 11 08 42 am

https://www.webpagetest.org/video/compare.php?tests=180725_WY_629a9c47602a77d93114d23463cd5ffc-r:1-c:0

When looking at the trace, it's clear the content is not present until ~4.1s, and the app appears to become interactive at ~3.8s. However, Lighthouse is marking the TTI at ~2.1s.

keanulee commented 6 years ago

There seems to be some discrepancy between the WPT timeline and Lighthouse numbers. I posted the Lighthouse numbers since that's what the other demos use. @addyosmani do you have any ideas?

housseindjirdeh commented 6 years ago

@keanulee Aside from that, the app works well and LGTM 🚀 (the favorites tab is a nice touch!)

Running traces on a few other apps and I'm noticing similar discrepancies. I still need to update all the numbers on the site to 3.0 so I'll check in with someone from the team about this before I do so

CC @addyosmani @pmeenan