tastejs / hacker-news-pwas

HNPWA - Hacker News readers as Progressive Web Apps 📱
https://hnpwa.com
2.38k stars 207 forks source link

Revisit contribution requirements #170

Open housseindjirdeh opened 5 years ago

housseindjirdeh commented 5 years ago

When we started this project, Lighthouse only gave a score for PWA:

screen shot 2018-12-04 at 9 48 47 am

A lot has changed since, where scores are provided along multiple areas:

screen shot 2018-12-04 at 9 51 11 am

@developit brought this up and made a very good point. There are a few things we can do here:

Updating this will tie in well to updating all scores to LH 3.0 via #60. We also should update how we display the scores on the site (ideally showing all of them)

jnorthrup commented 5 years ago

actually tbh, I'm under the impression that the lighthouse requirements are turning simple and concise PWA's into steaming piles of last-minute tweaks to bump up a few points here and there, and may cause wanton sloppy rewrites of simple working code.

I have started mentioning this to node developers I work with and that they may get lucky and find informative code in older git revisions of these formula-1 race-day editions.

the case may also be that this is homogenizing the options of the backend and front-end and ruling out entire classes of approach. i have to say these are not the kind of PWA's (style, features, usecases) my customers are interested in.