search

tastejs / nuxt-movies

Nuxt.js Movies - a TMDB client optimized for Core Web Vitals
https://nuxt-movies.vercel.app/
73 stars 24 forks source link

production deployment #48

Closed pi0 closed 3 years ago

pi0 commented 3 years ago

Vercel assumes main branch for production. We can rename current dev to main or create new main branch for staging/production deployments flow. /cc @addyosmani @anton-karlovskiy (related to #42)

anton-karlovskiy commented 3 years ago

@pi0 cc @addyosmani I think we have already the main branch so by creating a PR from dev against main, I think we can trigger production deployment. The purpose of using the dev branch was to separate the production branch (main) from the development branch (dev). In my experience, I think we can also configure the production branch name in the Vercel settings.

addyosmani commented 3 years ago

I think we have already the main branch so by creating a PR from dev against main, I think we can trigger production deployment.

This approach sounds reasonable to me and we've found it works relatively well in other projects.

anton-karlovskiy commented 3 years ago

@addyosmani Yes, it's done already. I think we can close this issue. FYI: I'm checking the issues and PRs in order to send a summary of them.