search

tastejs / todomvc

Helping you select an MV* framework - Todo apps for React.js, Ember.js, Angular, and many more
http://todomvc.com
Other
28.59k stars 13.78k forks source link

Focus on load #1029

Open sindresorhus opened 9 years ago

sindresorhus commented 9 years ago

Some apps are not focusing the new todo input on load:

@ColinEberhardt Do we test for this in the testsuite?

Also, would you be interested in fixing the GWT app?

ColinEberhardt commented 9 years ago

No, we don't test for this, because it's not in the spec ;-)

I'll see if I can add it in and do a full test run.

ColinEberhardt commented 9 years ago

Regarding GWT, I'm afraid I'll have to decline on that one. I haven't used GWT for a couple of years now (and don't miss it much!)

sindresorhus commented 9 years ago

No, we don't test for this, because it's not in the spec ;-)

It is now: https://github.com/tastejs/todomvc/commit/cc97e9c351cdb46e953c9b94bea5e32b44c9ec03

I'll see if I can add it in and do a full test run.

Awesome!

Regarding GWT, I'm afraid I'll have to decline on that one. I haven't used GWT for a couple of years now (and don't miss it much!)

No worries. Do you know anyone/anywhere we can reach out to?

ColinEberhardt commented 9 years ago

I've updated the test, and the failures I see are for

@sindresorhus that differs from your list slightly. I have manually verified extjs_deftjs and it works for me.

sindresorhus commented 9 years ago

I have manually verified extjs_deftjs and it works for me

Which browser? Focuses on load in Safari, but not in latest Chrome.

ColinEberhardt commented 9 years ago

Which browser? Focuses on load in Safari, but not in latest Chrome.

Just tried on 38.0.2125.104 (on a Mac), and it works fine.

sindresorhus commented 9 years ago

I'm on OS X 10.9 and can reproduce in Chrome Canary too (without any extensions enabled).

ColinEberhardt commented 9 years ago

I must be going mad, extjs_deftjs does repeatedly fail now:

$ mocha allTests.js --no-timeouts --reporter spec --grep initially --framework extjs_deftjs --no-colors 
  TodoMVC - extjs_deftjs
    When page is initially opened
      1) should focus on the todo input field

  0 passing (6s)
arthurvr commented 9 years ago

//cc @podefr @rse @corroded

podefr commented 9 years ago

Thanks again for the ping, will add this to Olives asap.

corroded commented 9 years ago

thanks for the ping. i haven't touched batman for a couple of years now (have been more focused in backbone tbh). Also, batman is not actively developed/maintained now :(

https://github.com/batmanjs/batman

podefr commented 9 years ago

Hey, I created #1242 which fixes the autofocus bug. Thanks!