search

tastejs / todomvc

Helping you select an MV* framework - Todo apps for React.js, Ember.js, Angular, and many more
http://todomvc.com
Other
28.55k stars 13.79k forks source link

Move Aurelia out of Labs #1963

Open EisenbergEffect opened 5 years ago

EisenbergEffect commented 5 years ago

Is there some reason why this project has insisted on keeping Aurelia in "labs" for three years? We have tens of thousands of customers in production with Aurelia. Is there some problem with what has been submitted? We would have been happy to fix any issues a long time ago. Can we please move this along? This is really frustrating.

FadySamirSadek commented 5 years ago

@EisenbergEffect Thank you so much for contributing to TodoMVC. I am very sorry you feel that way but it has been hard maintaining all the examples in TodoMVC and following up with framework changes. But TodoMVC is an open source project and it wouldn't have been possible without the awesome community and contributions. The Aurelia example has not been updated since 2016 and this is the first time anyone from the Aurelia community requested that we move the Aurelia example out of labs. That being said I think Aurelia is now mature enough and is complying with our example guidelines so once anyone from the Aurelia community opens a PR to update the example and move it out of labs. I'll review it and if everything is fine it'll be merged.

EisenbergEffect commented 5 years ago

Thank you @FadySamirSadek 😄 We can certainly get someone to work on this. Do you have some instructions on what needs to be done to move it out of labs? Is it just a matter of moving a folder from one place to another?

sindresorhus commented 5 years ago

Also ensure the example app is following the latest Aurelia best practices.

EisenbergEffect commented 5 years ago

@FadySamirSadek We have submitted a PR to update Aurelia. It's available here: https://github.com/tastejs/todomvc/pull/1969 It would be great to get this updated on that site. Thanks!