search

tastejs / todomvc

Helping you select an MV* framework - Todo apps for React.js, Ember.js, Angular, and many more
http://todomvc.com
Other
28.65k stars 13.77k forks source link

Add React Redux to Examples #2198

Closed flashdesignory closed 1 year ago

flashdesignory commented 1 year ago

This version has been lifted from Speedometer and follows the WebKit styles guide.

For more context regarding this update, please view https://github.com/tastejs/todomvc/issues/2199.

@kara

flashdesignory commented 1 year ago

While I believe some of my suggestions could enhance our work, I recognize that they might not align with our immediate objective of updating the examples.

Hi @FadySamirSadek - thank you for your review 🙏

For Speedometer, we made some decisions in regards to what version to upgrade to and what type of pattern to use to implement the todoMVC application. The big callout here is that we created two React versions.

  1. React Redux, which uses the most commonly used React and React-Redux version in combination with class components.
  2. React only, with functional components and hooks with a more recent React version (pr to come)

There could be an argument made to use React Toolkit vs React Redux, but that could be an additional community contribution that might be interesting to see.

There are multiple ways a React + Redux todoMVC app could be created. This is just one version that we chose that worked for our purpose.