Add URL prefix to ember app

[NullVoxPopuli]

Resolves https://github.com/tastejs/todomvc/issues/2235

Do we have a way to test this beforehand?

Locally, it runs at http://localhost:4200/examples/ember/

[flashdesignory]

@NullVoxPopuli - you can test it by spinning up the whole website locally. Please ensure to use the correct node version, otherwise it won't install correctly. Once done you should be able to run npm run gulp serve and then go to localhost:8080

Ideally you'd update the link in the index page and learn.json file as well to point to the dist folder.

[NullVoxPopuli]

Please ensure to use the correct node version, otherwise it won't install correctly.

woah, Node 8.17.0.

installation takes forever :upside_down_face:

Once done you should be able to run npm run gulp serve and then go to localhost:8080

thanks!

Ideally you'd update the link in the index page and learn.json file as well to point to the dist folder.

can do!

[NullVoxPopuli]

hm, installation isn't succeeding for me, I'm getting this:

❯ NODE_OPTIONS="" npm i
^C           ......] \ extract:unicode-5.2.0: sill extract unicode-5.2.0@0.7.5 extracted to /home/nvp/Development/OpenSource/todomvc/node_modules/.stagi
npm ERR! cb() never called!

npm ERR! This is an error with npm itself. Please report this error at:
npm ERR!     <https://npm.community>

npm ERR! A complete log of this run can be found in:
npm ERR!     /home/nvp/.npm/_logs/2024-01-18T17_04_56_168Z-debug.log

(I've had to ctrl+c, because it hung on extracting unicode)

[flashdesignory]

hmm I don't remember running into that issue. I can run your branch locally though, so if it's too much trouble I can verify for you.

[flashdesignory]

can we also change the links in the index.html and learn.json?

<a class="applist-item" href="examples/emberjs/todomvc/dist/" ... </a>

[NullVoxPopuli]

hmm I don't remember running into that issue.

any chance node can be upgraded to a supported version? :sweat_smile:

[NullVoxPopuli]

can we also change the links in the index.html and learn.json?

I've guessed at these values in the latest commit(s).

[flashdesignory]

any chance node can be upgraded to a supported version? 😅

It's on our todo list 😄

[NullVoxPopuli]

nit: we could delete emberjs/assets and emberjs/index.html I believe?

oh yeah, those symlinks -- those confused me, but now I understand why they were there. They are deleted.