tastejs / todomvc

Helping you select an MV* framework - Todo apps for React.js, Ember.js, Angular, and many more
http://todomvc.com
Other
28.59k stars 13.78k forks source link

Use Bower for dependency management #475

Closed passy closed 11 years ago

passy commented 11 years ago

All apps should use bower for dependency management if this is possible and does not interfere with the framework's best practices or their own dependency management.

In particular, every app should have a component.json on the root level and should link to the components/ directory from the index.html. The components/ directory should only contain the needed files, so we don't bloat the repository unnecessarily.

General Tasks

Pull requests are more than welcome! Please leave a comment before you start working on an app, so we can avoid overlaps.

paulmillr commented 11 years ago

Why bower? What if the workflow uses component(1)?

sindresorhus commented 11 years ago

@paulmillr

All apps should use bower for dependency management if this is possible and does not interfere with the framework's best practices or their own dependency management.

passy commented 11 years ago

I made a few updates to the spec. Feel free to make adjustments. I also added a task to update the template.

passy commented 11 years ago

Not ticking CanJS off the list yet, since two of the plugins aren't available as components yet.

rikkert commented 11 years ago

Would like to convert the Sammy.js app. Started work at rikkert/todomvc

passy commented 11 years ago

@rikkert Awesome. Go for it! :)

sindresorhus commented 11 years ago

@passy if they use valid semver git tags you can just register them yourself.

bower register name giturl

I did that for a few libs.

passy commented 11 years ago

@sindresorhus I created a repository for the localstorage plugin myself, because I couldn't find a canonical source for that. Looks like it was more like a snippet being copied around all the time. The mustache plugin, however, is part of the official repository but not distributed with their bower package. I'm going to open an issue for that.

For reference: https://github.com/bitovi/canjs/issues/252

addyosmani commented 11 years ago

If it would help to ask the community for more help with the conversion effort I'm happy to post about it.

passy commented 11 years ago

@addyosmani That could certainly help.

I tried converting the ember+require app today, but it's still using Ember 0.9.8.1 in a custom build with the router integrated which isn't available on bower. I think the time would be better spent porting it to 1.0rc2 instead of pushing the old releases on bower.

stephenplusplus commented 11 years ago

I'm going to give the Sammy.js example a shot. The style appears to be out of date, and the sammy.js library file itself is a couple versions behind. Is it worth the effort of re-styling and upgrading as well?

passy commented 11 years ago

@rikkert Did you make any progress on the sammy.js port?

addyosmani commented 11 years ago

' I think the time would be better spent porting it to 1.0rc2 instead of pushing the old releases on bower' agreed!

stephenplusplus commented 11 years ago

@passy I can't believe I missed that @rikkert already claimed it. I definitely remember reading his post, I guess the Sammy.js part didn't stick.

rikkert commented 11 years ago

Yes, I'm still working at it. Already moved to the latest version in bower. Should be done pretty soon.

On 3 apr. 2013, at 11:20, Stephen Sawchuk notifications@github.com wrote:

@passy I can't believe I missed that @rikkert already claimed it. I definitely remember reading his post, I guess the Sammy.js part didn't stick.

— Reply to this email directly or view it on GitHub.

stephenplusplus commented 11 years ago

They're all using Bower now :+1:

passy commented 11 years ago

Yay, closing! :cocktail:

addyosmani commented 11 years ago

Well done everyone!

sindresorhus commented 11 years ago

@addyosmani we should do the G+ post about it now. Did we have a draft doc?

addyosmani commented 11 years ago

I don't think we did but I agree. Let's put something together next week! On 23 May 2013 14:44, "Sindre Sorhus" notifications@github.com wrote:

@addyosmani https://github.com/addyosmani we should do the G+ post about it now. Did we have a draft doc?

— Reply to this email directly or view it on GitHubhttps://github.com/tastejs/todomvc/issues/475#issuecomment-18343862 .