PvP doesnt work at spawn with invincible visitors

[FrankHeijden]

PvP setting in /is settings at an /asadmin setspawn does not work. Tested on a clean paperspigot server, Paper version git-Paper-1188 (MC: 1.12.1) (Implementing API version 1.12.1-R0.1-SNAPSHOT), Vault 1.5.6-b49, ASkyBlock 3.0.7. PvP does work at players' islands.

Config settings tested with:

protection:
   world:
     ACID_DAMAGE: false
     ANVIL: true
     ARMOR_STAND: false
     BEACON: false
     BED: false
     BREAK_BLOCKS: false
     BREEDING: false
     BREWING: false
     BUCKET: false
     COLLECT_LAVA: false
     COLLECT_WATER: false
     CHEST: false
     CHORUS_FRUIT: false
     CRAFTING: true
     CREEPER_PAIN: true
     CROP_TRAMPLE: false
     DOOR: true
     EGGS: false
     ENCHANTING: true
     ENDER_PEARL: false
     ENTER_EXIT_MESSAGES: true
     FIRE: false
     FIRE_EXTINGUISH: false
     FIRE_SPREAD: false
     FURNACE: false
     GATE: false  
     HORSE_INVENTORY: false
     HORSE_RIDING: false
     HURT_MOBS: false
     HURT_MONSTERS: true
     LEASH: false
     LEVER_BUTTON: true
     MILKING: false
     MOB_SPAWN: true
     MONSTER_SPAWN: true
     MUSIC: false
     NETHER_PVP: true
     PLACE_BLOCKS: false
     PORTAL: true
     PRESSURE_PLATE: true
     PVP: true
     REDSTONE: false
     SPAWN_EGGS: false
     SHEARING: false
     VILLAGER_TRADING: true
     VISITOR_ITEM_DROP: true
     VISITOR_ITEM_PICKUP: true
   island:
     ACID_DAMAGE: false
     ANVIL: false
     ARMOR_STAND: false
     BEACON: false
     BED: false
     BREAK_BLOCKS: false
     BREEDING: false
     BREWING: false
     CHEST: false
     CHORUS_FRUIT: false
     CRAFTING: true
     CROP_TRAMPLE: false
     DOOR: false
     EGGS: false
     ENCHANTING: true
     ENDER_PEARL: false
     FIRE: false
     FIRE_EXTINGUISH: false
     FURNACE: false
     GATE: false   
     HORSE_INVENTORY: false
     HORSE_RIDING: false
     HURT_MOBS: false
     LEASH: false
     LEVER_BUTTON: false
     MILKING: false
     MUSIC: false
     PLACE_BLOCKS: false
     PORTAL: false
     PRESSURE_PLATE: false
     REDSTONE: false
     SPAWN_EGGS: false
     SHEARING: false
     VILLAGER_TRADING: false
     VISITOR_ITEM_DROP: false
     VISITOR_ITEM_PICKUP: false

[tastybento]

If you change it in config.yml, you need to flush it out to all the islands using /asadmin settingsreset pvp. Config.yml is for new islands only.

[FrankHeijden]

The PvP button in the GUI from /is settings doesn’t work. Thats the problem here

[tastybento]

Please take me through a step by step to replicate because I just tested and it works for me. i.e.:

1. Op player, go into creative
2. Tp to 10000 120 10000
3. /asadmin setspawn
4. /is settings
5. Tap the PVP - PVP is enabled.

[tastybento]

If you mean about a standard player's island - make sure they have the right permission, e.g. askyblock.settings.*

[FrankHeijden]

1. dragged this config file into a freshly generated askyblock 3.0.7 folder: (I PM'med you my config on spigotmc)
2. Op player, creative
3. created an island (/is)
4. tp to 0 100 0
5. /setblock ~ ~ ~ stone
6. on the stone /asadmin setspawn
7. /is settings - toggled PvP off
8. waited 60 secs /is settings - toggled PvP back on
9. • broken pvp -

[tastybento]

At step 9 does "broken pvp" mean that it doesn't toggle back? In my testing, the text "PvP allowed" comes up and the settings change. Apart from the cool down, I can toggle the setting. Is that the issue or something else? This is with a completely fresh install, only plugins are PermissionsEx, WorldEdit, Vault, ASkyBlock, Essentials.

version [15:27:46 INFO]: This server is running CraftBukkit version git-Spigot-65e8124-357b573 (MC: 1.12.1) (Implementing API version 1.12.1-R0.1-SNAPSHOT) [15:27:46 INFO]: Checking version, please wait... [15:27:48 INFO]: You are running the latest version

(By the way, there shouldn't be a 60 seconds cool down for Ops, so I'll fix that).

[FrankHeijden]

The toggle setting doesnt work indeed.

[tastybento]

Are you Op?

[FrankHeijden]

Yes

[tastybento]

Then I can't replicate, weird. Are there any other plugins on the server?

[FrankHeijden]

No, its completely empty

I sent you a zip file in a spigot conversation. This contains my whole test server (no worries, its just 6MB) for you to test out.

1) OP yourself 2) tp to X:0 Y:101 Z:0 3) try changing the PvP (arrow) setting in /is settings

[tastybento]

It works. Here's what I did (which is different to what you have above)

1. Oped myself
2. /island to make an island (because I was in another world)
3. tp to 0 101 0 (see the dirt)
4. /asadmin setspawn - sets this location to be the spawn
5. /is settings - hit the arrow, it toggles
6. Wait for 1 minute
7. /is settings - hit the arrow, it toggles back

Hmm.

[FrankHeijden]

The toggle works, but did you try to slap an alt? That didnt work for me when the setting was toggled off. I tried pvping at 0 101 0 and 16 blocks further (to see if spawnprotection was messing), but it wasn’t.

[tastybento]

Works okay for me. If PVP is not allowed, I see the "Target is in a no-PVP area" error, and if PVP is allowed you can hit the other player. You do need to remember to switch off creative mode otherwise the player cannot be hit.

[FrankHeijden]

I did xD so i dont see what im doing wrong, you can join my testserver if you want 91.121.145.119:30000

[tastybento]

Can you give me an FTP password so I can upload a debug version of the plugin?

[tastybento]

Issue was invincible visitors was set. Bug is that PVP should override invincible visitors at spawn.

[tastybento]

askyblock.jar.zip @FrankHeijden Can you try this build and see if it works correctly? It should allow PVP at spawn even if invincible visitors entity damage is on. Also, if visitors are being protected and they go to an island where PVP is allowed (normal island), attackers should see a "Visitors protected" error if they try to hit them or shoot them.

[tastybento]

Just tested myself. It is fixed. The only odd thing is that if PVP is allowed on an island but visitors are protected, visitors can hit island members, but cannot be damaged. To fix the admin will have to allow Entity Attack.