tastybento / ASkyBlock-Bugs-N-Features

Bug Tracker for ASkyBlock and AcidIsland - note team is 100% working on next version BentoBox
6 stars 3 forks source link

Challenges don't let me use raw or cooked things #912

Closed Max2124 closed 6 years ago

Max2124 commented 6 years ago

Thank you for filing a bug report. Please complete these sections to help speed resolution.

Server version? Remember to say if it is Spigot/Bukkit/Paper etc. Spigot 1.12.1 Plugin version: V3.0.9.4 Is this a new install or upgrade from earlier plugin version? If upgrade, what version did you use before? Actually using ASkyBlock 3.0.9.4 (Optional) What other plugins are you using now? (do /plugins and paste text from the console log here)

Description of issue. What happened? I wanted to make quests wich requiredItems are raw or cooked fish and animals meat, but it's not working. As challenge icon i use for example: "icon: RAW_BEEF" and it's working and shows the right material item but if i say as requiedeItems: "requiredItems: 'RAW_BEEF:64'" it won't let me complete the challenge because it don't know the items.

What do you think should happen? It shoul take those items and let me complete the challenge.

tastybento commented 6 years ago

The name is just BEEF, not RAW_BEEF

https://hub.spigotmc.org/javadocs/spigot/org/bukkit/Material.html#BEEF

Max2124 commented 6 years ago

Hey Tastybento unfortunatlly ASkyBlock gives me this in the console: [13:44:17 WARN] : [ASkyBlock] Error in challenges.yml - icon format is incorrect for lichtdesmeeres:BEEF [13:44:17 WARN] : [ASkyBlock] Format should be 'icon: MaterialType:Damage' whereDamage is optional [13:44:18 ERROR]: [ASkyBlock] Problem with BEEF:1 in challenges.yml! [13:44:18 ERROR]: [ASkyBlock] Did you mean BEEtROOT_BLOCK? [13:44:18 ERROR]: [ASkyBlock] Did you mean RAW_BEEF? [13:44:18 ERROR]: [ASkyBlock] Did you mean COOKED_BEEF? [13:44:18 ERROR]: [ASkyBlock] Did you mean BEETROOT? [13:44:18 ERROR]: [ASkyBlock] Did you mean BEETROOT? [13:44:18 ERROR]: [ASkyBlock] Did you mean BEETROOT_SEEDS?BEETROO_SOUP? [13:44:18 ERROR]: [ASkyBlock] Correct challenges.yml with the correct material.

Why is that happening? It also says this ingame in the chat if I try to complete the challenge "lichtdesmeeres" (It's german and means translated "lightofthesea". "You can't use that command right now. You do not have enough required item(s). Sammel 1 rohes Rindfleisch." It's just a test challenge that's why just 1 raw beef.

Poslovitch commented 6 years ago

There is something wrong with the YAML format. Please check the syntax here : http://yaml-online-parser.appspot.com/

Max2124 commented 6 years ago

How do I do that? just copy the part from my yaml?

Poslovitch commented 6 years ago

Yes.

Max2124 commented 6 years ago

If I do as you said it just gives me this below but doesn't show me any errors o_0

{ "lichtdesmeeres": { "expReward": 40, "itemReward": "SEA_LANTERN:32", "repeatRewardText": "&aDu bekommst 16 Seelaternen und 10 Erfahrungspunkte.", "icon": "BEEF", "maxtimes": 0, "requiredItems": "BEEF:1", "permissionReward": "", "repeatable": true, "repeatItemReward": "SEA_LANTERN:16", "friendlyname": "&bLicht des Meeres", "takeItems": true, "description": "&aSammel &e64 rohen Kabeljauch&a, &e32 rohen Lachs &aund &e4 rohen Kugelfisch&a.", "level": "\u00a7bTiefseetaucher", "rewardText": "&aDu bekommst &e32 Seelaternen &aund &e40 Erfahrungspunkte.", "repeatexpReward": 10, "resetallowed": true, "type": "inventory" } }

Poslovitch commented 6 years ago

Then, that's good. ASkyBlock is suggesting a few material names, because BEEF does not exist in 1.12.1. Have you tried them ?

[13:44:18 ERROR]: [ASkyBlock] Problem with BEEF:1 in challenges.yml!
[13:44:18 ERROR]: [ASkyBlock] Did you mean BEETROOT_BLOCK?
[13:44:18 ERROR]: [ASkyBlock] Did you mean RAW_BEEF?
[13:44:18 ERROR]: [ASkyBlock] Did you mean COOKED_BEEF?
[13:44:18 ERROR]: [ASkyBlock] Did you mean BEETROOT?
[13:44:18 ERROR]: [ASkyBlock] Did you mean BEETROOT_SOUP?
[13:44:18 ERROR]: [ASkyBlock] Did you mean BEETROOT_SEEDS?
Max2124 commented 6 years ago

Ok, now it's working with RAW_BEEF, but what is the materialname for raw pigmeat? RAW_PORK and RAW_PORKCHOP are both not working

Poslovitch commented 6 years ago

I don't know. As Spigot's javadocs get updated to the latest version, we can't access to the previous material names.

Max2124 commented 6 years ago

Ok, know it's working PORK an GRILLED_PORK was the right material id just like RABBIT and COOKED_RABBIT. Thanks for helping me Poslovitch :)

Poslovitch commented 6 years ago

Glad to help.