tastyigniter / TastyIgniter

:fire: Powerful, yet easy to use, open-source online ordering, table reservation and management system for restaurants
https://tastyigniter.com
MIT License
2.98k stars 976 forks source link

[Bug]: Postal code match issues #1025

Closed thek1d21 closed 1 year ago

thek1d21 commented 1 year ago

What happened?

Fresh install v3.6.0 (both wizard and composer). Server: VPS - Php 8.0.26, Ubuntu 22.04.1 Shared - Php both 8.0.x and 8.1.x - Ubunutu 22.02 Setup a restaurant, setup a delivery area -> Match by Postal Code: numeric ex: 28002 On the localSearch box on the home page u type the exact postal code and u get an error, Please enter your street address. Match by City or Locality on the delivery area settings didn't do trick either. With Google Maps api enabled y can get through if u use Polygon or Circle and u type in full addresses (copied from google maps exactly).

There is no system log error, nor console errors, nothing.

Captura de pantalla 2023-01-06 a las 15 16 36 Captura de pantalla 2023-01-06 a las 15 10 40

What did you expect to happen?

I expected it to work like it supposed to be, when you define Match by postal code, and u search that exact postal code it should match the restaurant that covers delivery in that postal code. Like in previous versions. In the demo version of TI that its autogenerated from the ti website it works flawlessly. I do not know what version is that.

P.S. Hard to believe that since the release of 3.6 in november no one noticed this bug, so i do really hope not wasting anyones time here.

Version

Other (please detail)

What browser are you seeing the problem on?

No response

Relevant log output

No response

thek1d21 commented 1 year ago

Yep, its definetly this https://github.com/tastyigniter/ti-ext-local/commit/2a4950bdaa2632f50d4f129d23762a488aa2d37e Removed those lines and now everything works fine, now it matches by postal code only, town only, or both etc... As it is a flaw in the local extension, maybe this bug req should be closed and a new one opened on the local extension page. My bad for opening here, sorry.

sampoyigi commented 1 year ago

Thank you for reporting... The idea was delivery addresses should always have a street name and in future can used to pre-fill the checkout form.

I've removed the street name check and the customer still has the option of entering a complete delivery address during checkout.

sampoyigi commented 1 year ago

https://github.com/tastyigniter/ti-ext-local/commit/3188840ca28f7d1a28c42e2d4eb2350abe7fbdd0