search

tastyigniter / TastyIgniter

:fire: Powerful, yet easy to use, open-source online ordering, table reservation and management system for restaurants
https://tastyigniter.com
MIT License
2.98k stars 966 forks source link

Clean JS files for case-insensitive file systems #1057

Closed heyanlong closed 6 months ago

heyanlong commented 9 months ago

When installing in case-insensitive operating systems, such as WSL2 and macOS, the case of the JS language file will be considered to be one file, and composer will cause an error.

sampoyigi commented 9 months ago

Can you add some description of what issue this is solving?

ObjectBoxPC commented 6 months ago

(Note: I am new to this codebase so my understanding of the situation may be incomplete.)

In this directory there appear to be "duplicate" locale files, some that use capital letters for the country code (for example "en-AU") and some that use lowercase letters ("en-au"). Files whose names differ only in letter case can cause problems on case-insensitive filenames. Besides that, they are confusing because it's not clear which one is actually being used for the given locale.

These appear to have been introduced in commit 415499ef24df4558ca78577b15c8b40caf3fcf3d .

sampoyigi commented 6 months ago

Thank you!