search

tastyigniter / TastyIgniter

:fire: Powerful, yet easy to use, open-source online ordering, table reservation and management system for restaurants
https://tastyigniter.com
MIT License
3.04k stars 997 forks source link

Date Format Ignored in Emails #370

Closed fede-exe closed 4 years ago

fede-exe commented 4 years ago

Expected behavior: in the setting> general> site section I set the date format in: ### dd / mm / yyyy and I expect that in the order confirmations (for example igniter.cart :: mail.order) sent by tastyigniter the date will be printed with this format.

Actual behavior: any format set is always displayed with gg Month 20

Reproduce steps: go to the menu, add what you want to eat, go to checkout, enter your details, choose how to pay and checkout. At this point an email will be sent to you and the format will not be what you previously set in the general parameter. The restaurant will also receive this email in the wrong format

Version: I find it on all versions v19, v20, v20.1

Additional Information: I don't think any further detail is needed but I'm probably wrong.

image

p3pp0 commented 4 years ago

can confirm this issue, Same for me

EDIT: same (am / pm added unneccesarily on more places) (see screenshot) image

EDIT2: can be accomplished by ADMIN-DESIGN-THEMES-LAYOUTS-LOCALLAYOUT...

ryanmitchell commented 4 years ago

I'm happy to take this bug on if its still unresolved in the develop branch.

It might not be the place to ask, but following on from the comment above, would it be worth considering that the setting in the admin panel takes universal effect, and the option to set dates within the components is removed.

At the moment if you want to change to a consistent date format on the front end it requires changing a few different places, and its easy to miss them, whereas one admin setting would be a lot simpler.

ryanmitchell commented 4 years ago

@fede-exe this has been completed and merged, would you mind closing the issue?

fede-exe commented 4 years ago

Sure thanks