tastyigniter / TastyIgniter

:fire: Powerful, yet easy to use, open-source online ordering, table reservation and management system for restaurants
https://tastyigniter.com
MIT License
3.01k stars 987 forks source link

Issue with adding allergens to sub menu items #526

Closed Gulfalpha closed 3 years ago

Gulfalpha commented 4 years ago

IExpected behavior: (I have created main category of Baguettes and Sandwiches where you can then go and choose a type of baguette, wrap, panini or sandwich. Under the selected baguette, wrap, panini or sandwich type selected, I have added baguette & sandwich fillings list & also an extras list and I would expect to be able to add a comprehensives list of allergens that are contained within the recipe that I am using of all the fillings and extra's. I would also like to add a brief description about the filling, along with a photograph, which should hopefully help generate more sales.

Actual behavior: (When you add the filling or extra item and try and add allergen information, it won't let me enter anything. There is nowhere to add a product description or a picture of the product)

Reproduce steps: (Create a sub menu, add names of fillings)

Version: (TastyIgniter version number: v3.0.4-beta.23.2)

Additional Information: (Any help would be very much appreciated)

ryanmitchell commented 4 years ago

@sampoyigi this carried over from a slack conversation, the main question is whether we allow multiple allergens on a menu item open - currently its 1:1

sampoyigi commented 4 years ago

Hmm, I'd let you decide on this one.

ryanmitchell commented 4 years ago

@babelattke what are your thoughts - any issues from the front end side with making allergens on menu_item_options more than 1:1 relationship?

babelattke commented 3 years ago

@ryanmitchell Sorry I never replied this thread. Please let me know if this issue still happening so I can work on it immediately.

ryanmitchell commented 3 years ago

Yeah it hasn’t moved on so let me know if you think it’s possible on the front end.

On 21 Nov 2020, at 16:08, Mauricio Lattke notifications@github.com wrote:

 @ryanmitchell Sorry I never replied this thread. Please let me know if this issue still happening so I can work on it immediately.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.

babelattke commented 3 years ago

@ryanmitchell I'm kinda lost. So basically what you want it's to display all the menu item allergens in the menu item modal?

ryanmitchell commented 3 years ago

Don’t worry it’s been a while!

At the moment you can only have 1 allergen on a menu item option. If we made it possible to have more than 1 would that affect things on the front end theme? I haven’t used allergens much so not sure if it will!

ryanmitchell commented 3 years ago

@babelattke just bumping this. Let me know as the backend change is pretty simple.

babelattke commented 3 years ago

@ryanmitchell is not supported at the moment. I'll work on it today and send a PR to the orange-theme.

ryanmitchell commented 3 years ago

Any progress @babelattke ? I've noticed that menu item options in the admin can already have more than 1 allergen associated with them due to the relation type in the code.

Currently we don't output any allergens associated with menu item options (handled by cartbox/item_modal.blade.php in cart extension). Unless I'm missing how/where we output them?

babelattke commented 3 years ago

@ryanmitchell I just sent the PR to cart extension.