search

tastyigniter / TastyIgniter

:fire: Powerful, yet easy to use, open-source online ordering, table reservation and management system for restaurants
https://tastyigniter.com
MIT License
3.03k stars 988 forks source link

[Bug]: valid postcodes being marked invalid #874

Closed joshuadempsey closed 3 years ago

joshuadempsey commented 3 years ago

What happened?

On the menu page, when entering a valid UK postal address I am getting the error "We couldn't locate the entered address or postcode, please enter a valid address or postcode."

The postcode is in format xxxxxx, however when I split it up into xxx xxx, it is accepted as valid. I think this shouldn't be the case, and the first format should be accepted too. I am sure it worked correctly on prior versions of TI. Using version 3.1.1

What did you expect to happen?

To accept the postal address as valid.

Version

Other (please detail)

What browser are you seeing the problem on?

Chrome

Relevant log output

"We couldn't locate the entered address or postcode, please enter a valid address or postcode"
ryanmitchell commented 3 years ago

Would be good to know the actual postcode and your restaurant location details so this can be tested and verified

joshuadempsey commented 3 years ago

Would be good to know the actual postcode and your restaurant location details so this can be tested and verified

Thanks for your quick reply. Can you please message me privately on Discord and I will be happy to provide these. Thank you.

ryanmitchell commented 3 years ago

@joshuadempsey did you get a chance to test this using Google maps?

joshuadempsey commented 3 years ago

@joshuadempsey did you get a chance to test this using Google maps?

Not as of yet, will hopefully meet client this afternoon and get back to you. Thanks.

joshuadempsey commented 3 years ago

I fixed this by turning off restrictions on my API key. Is there any way this key is exposed, therefore allowing malicious actors to use it?

Thanks

ryanmitchell commented 3 years ago

No, the key is only used on the backend admin panel JS and in PHP code.

On 21 Oct 2021, at 20:25, Joshua Dempsey @.***> wrote:

 I fixed this by turning off restrictions on my API key. Is there any way this key is exposed, therefore allowing malicious actors to use it?

Thanks

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or unsubscribe.

joshuadempsey commented 3 years ago

Brilliant cheers.