Add MySQL8 to actions for testing

tastyigniter / TastyIgniter

:fire: Powerful, yet easy to use, open-source online ordering, table reservation and management system for restaurants

https://tastyigniter.com

MIT License

3.03k stars 988 forks source link

Add MySQL8 to actions for testing #903

Closed ryanmitchell closed 2 years ago

ryanmitchell commented 2 years ago

Should we also add some different versions of MariaDB?

ryanmitchell commented 2 years ago

@sampoyigi so thats this working as long as I set DB_PREFIX to be blank, which makes me think theres a bug in App::hasDatabase() not taking into account the prefix... does that seem possible to you? Try setting the DB_PREFIX env variable to have a value and re-run the tests here to see the error.

sampoyigi commented 2 years ago

The DB prefix does get added here https://github.com/illuminate/database/blob/aad650ceb4a258ac113e5f9f83fda8c66e9083cf/Schema/MySqlBuilder.php#L41

Should we also add some different versions of MariaDB?

Yup

sampoyigi commented 2 years ago

Sweet! Removing the prefix from the DB name worked ;)