tastyigniter / ti-ext-payregister

Payment system for TastyIgniter. Allows you to accept credit card payments using payment gateway supplied by this extension or others.
MIT License
8 stars 21 forks source link

Update process.square.js to use the WebPayments SDK instead of SqPaymentForm #31

Closed CupNoodles closed 3 years ago

CupNoodles commented 3 years ago

Deprecation warning no longer shows up in the web console.

I've only tested in sandbox, but can confirm that behaviors are the same between the old SqPaymentForms implementation and this one. I've 'tested' the SCA process in sandbox with the values described in https://developer.squareup.com/docs/testing/test-values, but as I don't have an EU bank account I have no clue what this looks like in production.

sampoyigi commented 3 years ago

Apart from the requested changes, everything else appears to be in order, and I'll come back later to further check and test it. Thank you for your time and work!

CupNoodles commented 3 years ago

Moved the card styles over! Should I be trying to fix these CI failures?

sampoyigi commented 3 years ago

Yup

sampoyigi commented 3 years ago

Thank you for your efforts; apart from a typo with the verificationToken, I was able to test without issue.