tastyigniter / ti-ext-payregister

Payment system for TastyIgniter. Allows you to accept credit card payments using payment gateway supplied by this extension or others.
MIT License
8 stars 21 forks source link

replace Omnipay Square handling with square/square php SDK #45

Closed CupNoodles closed 1 year ago

CupNoodles commented 1 year ago

https://github.com/tastyigniter/ti-ext-payregister/issues/40 requires changed to vendor-ed code in order to log tip amounts in Square (which is necessary for tip-outs to staff when using Square as your payment platform).

This PR drops the dependency on omnipay's square gateway, but adds a dependency on the square PHP SDK square/square.

I've done some happy-path testing to confirm that the following work as expected on TI 3.6.1

I have a production environment that I can test this on as well, but it doesn't utilize payment profiles and will only really test the 'Payment for an order when not logged in' case. Frankly, I'm not too familiar with the payment profile code at all and some scrutiny would be appreciated.

sampoyigi commented 1 year ago

Thank you for the PR!